docs: fix two broken tutorial notebook links in README - #524
Open
vaibhav8a wants to merge 1 commit into
Open
Conversation
DTGS172 pointed at DTGS172_custom_scatterers_bacteria.ipynb and DTAT355 pointed at DTAT_387_types.ipynb; neither file exists. The actual notebooks are DTGS172_bacteria.ipynb and DTAT355_types.ipynb. Both the GitHub link and the Colab badge href were 404ing on each entry.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two tutorial links in the README point at notebook filenames that don't exist on
develop, so both the GitHub link and the "Open in Colab" badge 404.developtutorials/1-getting-started/DTGS172_custom_scatterers_bacteria.ipynbtutorials/1-getting-started/DTGS172_bacteria.ipynbtutorials/3-advanced-topics/DTAT_387_types.ipynbtutorials/3-advanced-topics/DTAT355_types.ipynbBoth corrections are unambiguous: the
DTGS172_andDTAT355prefixes in the README's own entry labels match exactly one notebook each in the tree, and no notebook by either linked name exists on any branch.Each line carries the path twice (the markdown link and the Colab badge
href), so four occurrences were updated in total. README-only change.